Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10192 )
Change subject: IMPALA-6927: Remove invalid DCHECK from coordinator backend state ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10192/1/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: http://gerrit.cloudera.org:8080/#/c/10192/1/be/src/runtime/coordinator-backend-state.cc@a619 PS1, Line 619: > This LGTM, but is there any point in having the DCHECK and checking like so I'm not sure whether that value forces the exact number of instances per fragment or is rather treated as an upper bound. I also wasn't sure whether it would apply to all fragments or only some. Do you know if both are true? -- To view, visit http://gerrit.cloudera.org:8080/10192 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4ea4d583c6ab3fc788db8e220c0a1891918a823f Gerrit-Change-Number: 10192 Gerrit-PatchSet: 1 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Wed, 25 Apr 2018 19:52:30 +0000 Gerrit-HasComments: Yes
