Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10192 )
Change subject: IMPALA-6927: Remove invalid DCHECK from coordinator backend state ...................................................................... IMPALA-6927: Remove invalid DCHECK from coordinator backend state An invalid DCHECK in Coordinator::BackendState::InstanceStatsToJson() assumed that the number of fragment instances is equal to the number of fragments. This is not true when mt_dop > 0, which results in multiple instances of a fragment on a single node. The fix is to remove the invalid DCHECK. It served to document the programmers understanding and the code does not rely on the assumption being true. This change adds a test that would fail with the DCHECK in place. Change-Id: I4ea4d583c6ab3fc788db8e220c0a1891918a823f Reviewed-on: http://gerrit.cloudera.org:8080/10192 Reviewed-by: Sailesh Mukil <sail...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M be/src/runtime/coordinator-backend-state.cc M tests/webserver/test_web_pages.py 2 files changed, 13 insertions(+), 2 deletions(-) Approvals: Sailesh Mukil: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10192 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I4ea4d583c6ab3fc788db8e220c0a1891918a823f Gerrit-Change-Number: 10192 Gerrit-PatchSet: 2 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com>
