Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20799 )
Change subject: IMPALA-12633: Restore checking inflight in retry ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20799/1/be/src/runtime/query-driver.cc File be/src/runtime/query-driver.cc: http://gerrit.cloudera.org:8080/#/c/20799/1/be/src/runtime/query-driver.cc@376 PS1, Line 376: // If the query's not yet inflight, skip it. It should be unregistered later. > This makes me uneasy. I don't see a reason we would want to skip cleanup be Should this be if (!query_handle->is_inflight()) return; -- To view, visit http://gerrit.cloudera.org:8080/20799 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic17a5e12d9db61cb19306270174518a8dfd281a7 Gerrit-Change-Number: 20799 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 15 Dec 2023 04:20:55 +0000 Gerrit-HasComments: Yes
