Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20799 )
Change subject: IMPALA-12633: Remove DCHECK for slow SetQueryInflight ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/20799/3/be/src/runtime/query-driver.cc File be/src/runtime/query-driver.cc: http://gerrit.cloudera.org:8080/#/c/20799/3/be/src/runtime/query-driver.cc@375 PS3, Line 375: It's possible (but rare) : // that the query is not marked inflight yet; what happens in that case is: Question: this looks like a fair number of concurrency scenario. Is it possible to identify the code path and put WARNING log for each case? Or make it more deterministic to eliminate some possible scenario? http://gerrit.cloudera.org:8080/#/c/20799/3/be/src/runtime/query-driver.cc@380 PS3, Line 380: 1. nit: 3 -- To view, visit http://gerrit.cloudera.org:8080/20799 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic17a5e12d9db61cb19306270174518a8dfd281a7 Gerrit-Change-Number: 20799 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 15 Dec 2023 20:48:26 +0000 Gerrit-HasComments: Yes
