Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20731 )
Change subject: IMPALA-12502: Support Impala to Impala federation ...................................................................... Patch Set 16: (4 comments) http://gerrit.cloudera.org:8080/#/c/20731/15/fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java File fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java: http://gerrit.cloudera.org:8080/#/c/20731/15/fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java@737 PS15, Line 737: String downloadImpalaJdbcDriver = new File(System.getenv("IMPALA_HOME"), > ImpalaJdbcClient uses HiveJdbc. Any reason we can't use that? Simba jdbc driver is recommended driver. Tried Hive jdbc driver, it does not work with dbcp and connection hang. JDBC external data source use dbcp to create DB connections, ImpalaJdbcClient use driver to create DB connection directly. http://gerrit.cloudera.org:8080/#/c/20731/15/testdata/bin/download-impala-jdbc-driver.sh File testdata/bin/download-impala-jdbc-driver.sh: http://gerrit.cloudera.org:8080/#/c/20731/15/testdata/bin/download-impala-jdbc-driver.sh@39 PS15, Line 39: > The version to download would make sense as an environment variable in impa Defined Sibma driver version in impala-config.sh. Also check if the driver jar exists in HDFS before downloading. http://gerrit.cloudera.org:8080/#/c/20731/15/tests/custom_cluster/test_ext_data_sources.py File tests/custom_cluster/test_ext_data_sources.py: http://gerrit.cloudera.org:8080/#/c/20731/15/tests/custom_cluster/test_ext_data_sources.py@122 PS15, Line 122: download > Nit: download Thanks to point out. Fixed. http://gerrit.cloudera.org:8080/#/c/20731/15/tests/custom_cluster/test_ext_data_sources.py@125 PS15, Line 125: os.environ['IMPALA_HOME'], 'testdata/bin/download-impala-jdbc-driver.sh') > This setup seems strange. We already have ImpalaJdbcClient.java which produ Yes, we use Simba jdbc driver which is not included in Impala repo. -- To view, visit http://gerrit.cloudera.org:8080/20731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79ad3273932b658cb85c9c17cc834fa1b5fbd64f Gerrit-Change-Number: 20731 Gerrit-PatchSet: 16 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 21 Dec 2023 02:22:19 +0000 Gerrit-HasComments: Yes
