Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20731 )
Change subject: IMPALA-12502: Support Impala to Impala federation ...................................................................... Patch Set 17: (4 comments) http://gerrit.cloudera.org:8080/#/c/20731/17/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/20731/17/bin/impala-config.sh@192 PS17, Line 192: unset IMPALA_SIMBA_JDBC_DRIVER_URL nit: This URL is used in bootstrap_toolchain.py, we probably don't need it. And since this is something we're downloading separately, I'd separate it from the other versions here. http://gerrit.cloudera.org:8080/#/c/20731/15/fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java File fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java: http://gerrit.cloudera.org:8080/#/c/20731/15/fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java@737 PS15, Line 737: String downloadImpalaJdbcDriver = new File(System.getenv("IMPALA_HOME"), > Simba jdbc driver is recommended driver. Tried Hive jdbc driver, it does no Ack http://gerrit.cloudera.org:8080/#/c/20731/17/testdata/bin/download-impala-jdbc-driver.sh File testdata/bin/download-impala-jdbc-driver.sh: http://gerrit.cloudera.org:8080/#/c/20731/17/testdata/bin/download-impala-jdbc-driver.sh@32 PS17, Line 32: SIMBA_DRIVER_JAR_FILENAME=ImpalaJDBC42.jar Version really ends up in a lot of things. We could extract 42 from IMPALA_SIMBA_JDBC_DRIVER_VERSION, but I'm comfortable leaving that for the next time we update this too. http://gerrit.cloudera.org:8080/#/c/20731/17/testdata/bin/download-impala-jdbc-driver.sh@36 PS17, Line 36: echo "JDBC driver jar file is already exist" nit: "file already exists" -- To view, visit http://gerrit.cloudera.org:8080/20731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79ad3273932b658cb85c9c17cc834fa1b5fbd64f Gerrit-Change-Number: 20731 Gerrit-PatchSet: 17 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 21 Dec 2023 17:40:48 +0000 Gerrit-HasComments: Yes
