Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20852 )
Change subject: IMPALA-12681: Release file descriptors for partial written temporary files ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20852/1/be/src/runtime/io/disk-file.cc File be/src/runtime/io/disk-file.cc: http://gerrit.cloudera.org:8080/#/c/20852/1/be/src/runtime/io/disk-file.cc@41 PS1, Line 41: if (file_writer_ != nullptr) { : file_writer_.reset(); : } Is it safe to delete it here, so can we exclude the possibility of having pointers to file_writer_ elsewhere? It seems safer to me to call Close here and possibly add a DCHECK to the destructor of LocalFileWriter to check that the file was closed. -- To view, visit http://gerrit.cloudera.org:8080/20852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58a2bac419ced806d6f5a32bcdf24d79e078ab14 Gerrit-Change-Number: 20852 Gerrit-PatchSet: 1 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 04 Jan 2024 08:28:01 +0000 Gerrit-HasComments: Yes
