Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20852 )
Change subject: IMPALA-12681: Release file descriptors for partial written temporary files ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/20852/1/be/src/runtime/io/disk-file.cc File be/src/runtime/io/disk-file.cc: http://gerrit.cloudera.org:8080/#/c/20852/1/be/src/runtime/io/disk-file.cc@41 PS1, Line 41: // Close the file writer to release the file handle. : RETURN_IF_ERROR(file_writer_->Close()); : } > Is it safe to delete it here, so can we exclude the possibility of having p Thanks Csaba! Yeah, it is better to call Close() here and add a DCHECK in the destructor of file writer. Changed. -- To view, visit http://gerrit.cloudera.org:8080/20852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58a2bac419ced806d6f5a32bcdf24d79e078ab14 Gerrit-Change-Number: 20852 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 04 Jan 2024 09:06:19 +0000 Gerrit-HasComments: Yes
