Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20852 )
Change subject: IMPALA-12681: Release file descriptors for partially written temporary files ...................................................................... Patch Set 6: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/20852/6/tests/custom_cluster/test_scratch_disk.py File tests/custom_cluster/test_scratch_disk.py: http://gerrit.cloudera.org:8080/#/c/20852/6/tests/custom_cluster/test_scratch_disk.py@288 PS6, Line 288: result = subprocess.check_output(command, shell=True) : return result.strip() nit: -2 indentation http://gerrit.cloudera.org:8080/#/c/20852/6/tests/custom_cluster/test_scratch_disk.py@291 PS6, Line 291: if not e.output: : # If there is no output, return None. : return None : return "Error checking the fd path with error '{}'".format(e) nit: -2 indentation -- To view, visit http://gerrit.cloudera.org:8080/20852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58a2bac419ced806d6f5a32bcdf24d79e078ab14 Gerrit-Change-Number: 20852 Gerrit-PatchSet: 6 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 08 Jan 2024 11:56:18 +0000 Gerrit-HasComments: Yes
