Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/20852 )
Change subject: IMPALA-12681: Release file descriptors for partially written temporary files ...................................................................... Patch Set 4: Code-Review+1 Would be good to also test some cases where spilling queries get killed either by user or fail for other reasons and in such cases do we cleanup resources properly? We could also inspect the error code path. -- To view, visit http://gerrit.cloudera.org:8080/20852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58a2bac419ced806d6f5a32bcdf24d79e078ab14 Gerrit-Change-Number: 20852 Gerrit-PatchSet: 4 Gerrit-Owner: Yida Wu <wydbaggio...@gmail.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Thu, 04 Jan 2024 18:02:09 +0000 Gerrit-HasComments: No