Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20907 )
Change subject: IMPALA-11710: Table properties are not updated in Iceberg metadata files ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/20907/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20907/2//COMMIT_MSG@23 PS2, Line 23: that : didn't specify 'external.table.purge'='true' Could you expand a bit on how 'external.table.purge'='true' should be related to the return value of CatalogOpExecutor.alterIcebergTables()? E.g. should it return false in all cases if 'external.table.purge' is not true? -- To view, visit http://gerrit.cloudera.org:8080/20907 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a82d022534e1e212d542fbd7916ae033c381c20 Gerrit-Change-Number: 20907 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 17 Jan 2024 15:47:10 +0000 Gerrit-HasComments: Yes
