Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20907 )
Change subject: IMPALA-11710: Table properties are not updated in Iceberg metadata files ...................................................................... Patch Set 2: (1 comment) Thanks for the comment! http://gerrit.cloudera.org:8080/#/c/20907/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20907/2//COMMIT_MSG@23 PS2, Line 23: that : didn't specify 'external.table.purge'='true' > Could you expand a bit on how 'external.table.purge'='true' should be relat CatalogOpExecutor.alterIcebergTables()'s return value is explained in the earlier paragraph: "the HMS table definition is always updated by the Iceberg library if the table is handled by the HiveCatalog. In every other case we need to update the HMS table definition ourselves." I.e. 'external.table.purge'='true' has no role in the return value of CatalogOpExecutor.alterIcebergTables() anymore. I updated the comment of CatalogOpExecutor.alterIcebergTables(). -- To view, visit http://gerrit.cloudera.org:8080/20907 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a82d022534e1e212d542fbd7916ae033c381c20 Gerrit-Change-Number: 20907 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 18 Jan 2024 10:26:31 +0000 Gerrit-HasComments: Yes
