Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20682 )
Change subject: IMPALA-9086: Show Hive configurations in /hadoop-varz page ...................................................................... Patch Set 9: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/20682/6/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/20682/6/be/src/catalog/catalog-server.cc@1092 PS6, Line 1092: document); > We should log and return an error if this fails. Done http://gerrit.cloudera.org:8080/#/c/20682/6/be/src/catalog/catalog-server.cc@1096 PS6, Line 1096: CatalogOpListToJson(response.finished_catalog_operations, &finished_catalog_ops, > I think 'const auto&' would be acceptable here. value_type is no more illum Done http://gerrit.cloudera.org:8080/#/c/20682/6/fe/src/main/java/org/apache/impala/service/JniFrontend.java File fe/src/main/java/org/apache/impala/service/JniFrontend.java: http://gerrit.cloudera.org:8080/#/c/20682/6/fe/src/main/java/org/apache/impala/service/JniFrontend.java@a628 PS6, Line 628: > Why remove this comment? HIVE_CONF isn't replacing all uses of CONF. Althou Done -- To view, visit http://gerrit.cloudera.org:8080/20682 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5af0eb68e71afeed64660d4d40584208ea503217 Gerrit-Change-Number: 20682 Gerrit-PatchSet: 9 Gerrit-Owner: Saurabh Katiyal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Saurabh Katiyal <[email protected]> Gerrit-Comment-Date: Mon, 22 Jan 2024 21:25:11 +0000 Gerrit-HasComments: Yes
