Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20682 )
Change subject: IMPALA-9086: Show Hive configurations in /hadoop-varz page ...................................................................... Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/20682/7/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/20682/7/be/src/catalog/catalog-server.cc@1093 PS7, Line 1093: document->AddMember("inflight_catalog_operations", inflight_catalog_ops, > line too long (96 > 90) Can we keep this log? We just need to wrap the line. LOG(ERROR) << "Error getting cluster configuration for hadoop-varz: " << status.GetDetail(); http://gerrit.cloudera.org:8080/#/c/20682/9/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/20682/9/be/src/catalog/catalog-server.cc@1182 PS9, Line 1182: } nit: fix the indent. Should have only two spaces. http://gerrit.cloudera.org:8080/#/c/20682/7/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/20682/7/be/src/service/impala-http-handler.cc@234 PS7, Line 234: Value error(status.GetDetail().c_str(), document->GetAllocator()); > line too long (96 > 90) Can we keep this log? -- To view, visit http://gerrit.cloudera.org:8080/20682 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5af0eb68e71afeed64660d4d40584208ea503217 Gerrit-Change-Number: 20682 Gerrit-PatchSet: 9 Gerrit-Owner: Saurabh Katiyal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Saurabh Katiyal <[email protected]> Gerrit-Comment-Date: Tue, 23 Jan 2024 08:13:54 +0000 Gerrit-HasComments: Yes
