Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20956 )
Change subject: IMPALA-12747: Atomic update of execution state ...................................................................... Patch Set 6: (2 comments) > Patch Set 2: Verified-1 > > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/10198/ It seems there are issues on redaction: custom_cluster/test_redaction.py:298: in test_redacted self.assert_log_redaction(credit_card, "\*credit card\*", expect_audit=False) custom_cluster/test_redaction.py:133: in assert_log_redaction assert_no_files_in_dir_contain(self.audit_dir, unredacted_value) common/file_utils.py:178: in assert_no_files_in_dir_contain % (dir, search) E AssertionError: /home/ubuntu/Impala/logs/custom_cluster_tests/test_redaction_fvRZ3Z/audits should not have any file containing '1234-5678-1234-5678' but a file was found http://gerrit.cloudera.org:8080/#/c/20956/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20956/6//COMMIT_MSG@9 PS6, Line 9: QueryStateRecord "QueryDriver" ? http://gerrit.cloudera.org:8080/#/c/20956/6/be/src/runtime/query-driver.cc File be/src/runtime/query-driver.cc: http://gerrit.cloudera.org:8080/#/c/20956/6/be/src/runtime/query-driver.cc@119 PS6, Line 119: RETURN_IF_ERROR(DoFrontendPlanning(query_ctx, false)); Why we need to do planning here? Isn't the 'external_exec_request' already the TExecRequest to use? EDIT: Just realized it's an existing behavior. Can we comment it somewhere that we want one from the Impala planner to compare with? -- To view, visit http://gerrit.cloudera.org:8080/20956 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a967c5c84b6a401f8f5764373f6cd7ee807545f Gerrit-Change-Number: 20956 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 26 Jan 2024 08:46:28 +0000 Gerrit-HasComments: Yes
