Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20956 )

Change subject: IMPALA-12747: Atomic update of execution state
......................................................................


Patch Set 6:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/20956/5//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/20956/5//COMMIT_MSG@21
PS5, Line 21: queries in the web
            : UI
> What UI operation that trigger the race before?
Is that not clear? You call GET /queries, which constructs a QueryStateRecord.


http://gerrit.cloudera.org:8080/#/c/20956/5//COMMIT_MSG@28
PS5, Line 28: default
            :   initialized in Thrift).
> nit: this is now an explicit init stmt_type = TStmtType.UNKNOWN in Frontend
Done


http://gerrit.cloudera.org:8080/#/c/20956/5/be/src/runtime/query-driver.h
File be/src/runtime/query-driver.h:

http://gerrit.cloudera.org:8080/#/c/20956/5/be/src/runtime/query-driver.h@229
PS5, Line 229:   /// result from SetExternalPlan to dump_exec_request_path 
without redundant work.
> Document what use_request for.
Done



--
To view, visit http://gerrit.cloudera.org:8080/20956
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a967c5c84b6a401f8f5764373f6cd7ee807545f
Gerrit-Change-Number: 20956
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Fri, 26 Jan 2024 01:03:49 +0000
Gerrit-HasComments: Yes

Reply via email to