Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20770 )
Change subject: IMPALA-12426: Query History Table ...................................................................... Patch Set 13: (3 comments) http://gerrit.cloudera.org:8080/#/c/20770/12/be/src/util/runtime-profile.h File be/src/util/runtime-profile.h: http://gerrit.cloudera.org:8080/#/c/20770/12/be/src/util/runtime-profile.h@257 PS12, Line 257: CounterMap counter_map_; > How about updating the implementation of GetCounter to use const accessors Done http://gerrit.cloudera.org:8080/#/c/20770/13/be/src/util/string-util.cc File be/src/util/string-util.cc: http://gerrit.cloudera.org:8080/#/c/20770/13/be/src/util/string-util.cc@198 PS13, Line 198: if (!str().empty()) { str() can be expensive, it makes a copy of the underlying string. Use tellp() > 0 instead. http://gerrit.cloudera.org:8080/#/c/20770/13/be/src/util/uid-util.h File be/src/util/uid-util.h: http://gerrit.cloudera.org:8080/#/c/20770/13/be/src/util/uid-util.h@134 PS13, Line 134: inline bool is_uuid_empty(const TUniqueId& id) { Seems like this should be IsUUIDEmpty to match other functions in this header. -- To view, visit http://gerrit.cloudera.org:8080/20770 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d2da9d450fba4e789400cfa62927fc25d34f844 Gerrit-Change-Number: 20770 Gerrit-PatchSet: 13 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 26 Jan 2024 22:35:32 +0000 Gerrit-HasComments: Yes
