Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20770 )
Change subject: IMPALA-12426: Query History Table ...................................................................... Patch Set 13: (3 comments) http://gerrit.cloudera.org:8080/#/c/20770/13/be/src/service/workload-management.cc File be/src/service/workload-management.cc: http://gerrit.cloudera.org:8080/#/c/20770/13/be/src/service/workload-management.cc@461 PS13, Line 461: remove_leading_newlines(formatted_plan); Can we remove these when we store it instead? http://gerrit.cloudera.org:8080/#/c/20770/13/be/src/util/string-util.h File be/src/util/string-util.h: http://gerrit.cloudera.org:8080/#/c/20770/13/be/src/util/string-util.h@105 PS13, Line 105: void to_snake_case(const std::string& in, std::stringstream* out); nit: ToSnakeCase to match other function names. http://gerrit.cloudera.org:8080/#/c/20770/13/be/src/util/string-util.h@119 PS13, Line 119: void remove_leading_newlines(std::string& str); This is pretty easy and probably more performant as boost::algorithm::trim_left_if(str, boost::algorithm::is_any_of("\n")); -- To view, visit http://gerrit.cloudera.org:8080/20770 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d2da9d450fba4e789400cfa62927fc25d34f844 Gerrit-Change-Number: 20770 Gerrit-PatchSet: 13 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 26 Jan 2024 23:46:47 +0000 Gerrit-HasComments: Yes
