Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20867 )
Change subject: IMPALA-12688: Support JSON profile imports for in webUI ...................................................................... Patch Set 3: (3 comments) looks good http://gerrit.cloudera.org:8080/#/c/20867/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20867/3//COMMIT_MSG@7 PS3, Line 7: in nit: remove 'in' http://gerrit.cloudera.org:8080/#/c/20867/3/www/queries.tmpl File www/queries.tmpl: http://gerrit.cloudera.org:8080/#/c/20867/3/www/queries.tmpl@218 PS3, Line 218: [?] why need '?' http://gerrit.cloudera.org:8080/#/c/20867/2/www/query_plan_text.tmpl File www/query_plan_text.tmpl: http://gerrit.cloudera.org:8080/#/c/20867/2/www/query_plan_text.tmpl@33 PS2, Line 33: "Query", "Timeline", "Text plan" > This requires quite a bit of client-side code to reproduce, as the profile It's not necessary in this patch -- To view, visit http://gerrit.cloudera.org:8080/20867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife6eb59bf2030fd19fc92aaf134eb51c609e04d0 Gerrit-Change-Number: 20867 Gerrit-PatchSet: 3 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 30 Jan 2024 18:34:02 +0000 Gerrit-HasComments: Yes
