Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/20867 )
Change subject: IMPALA-12688: Support JSON profile imports in webUI ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/20867/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20867/3//COMMIT_MSG@7 PS3, Line 7: eb > nit: remove 'in' Done http://gerrit.cloudera.org:8080/#/c/20867/3//COMMIT_MSG@11 PS3, Line 11: system dialog > correction: sometimes the selected files are NOT imported. If we drop some fields in the imported profiles section, then it may be possible to parse the profile. But I am not sure, how much older profiles should be supported. The past few month's profiles have been working fine. I am not sure when exactly these fields did not exist. http://gerrit.cloudera.org:8080/#/c/20867/3//COMMIT_MSG@11 PS3, Line 11: system dialog > One minor issue. When clicking "Open" button after selecting a json file or I had tested on some profiles that were older than 2023 January, since they were missing some fields such as "Duration". Hence, these were resulting in parsing errors. http://gerrit.cloudera.org:8080/#/c/20867/3/www/queries.tmpl File www/queries.tmpl: http://gerrit.cloudera.org:8080/#/c/20867/3/www/queries.tmpl@218 PS3, Line 218: [?] > why need '?' It was just to maintain consistency with the above sections. http://gerrit.cloudera.org:8080/#/c/20867/2/www/query_plan_text.tmpl File www/query_plan_text.tmpl: http://gerrit.cloudera.org:8080/#/c/20867/2/www/query_plan_text.tmpl@33 PS2, Line 33: "Query", "Timeline", "Text plan" > It's not necessary in this patch Okay. -- To view, visit http://gerrit.cloudera.org:8080/20867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife6eb59bf2030fd19fc92aaf134eb51c609e04d0 Gerrit-Change-Number: 20867 Gerrit-PatchSet: 4 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 02 Feb 2024 13:11:12 +0000 Gerrit-HasComments: Yes
