Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20926 )
Change subject: IMPALA-12718: Provides UTF-8 support for the trim functions ...................................................................... Patch Set 10: Code-Review+1 (2 comments) The patch looks pretty good! http://gerrit.cloudera.org:8080/#/c/20926/10/be/src/util/bit-util.h File be/src/util/bit-util.h: http://gerrit.cloudera.org:8080/#/c/20926/10/be/src/util/bit-util.h@139 PS10, Line 139: int We can use int8_t to save some space in the precomputed table. http://gerrit.cloudera.org:8080/#/c/20926/10/testdata/workloads/functional-query/queries/QueryTest/utf8-string-functions.test File testdata/workloads/functional-query/queries/QueryTest/utf8-string-functions.test: http://gerrit.cloudera.org:8080/#/c/20926/10/testdata/workloads/functional-query/queries/QueryTest/utf8-string-functions.test@332 PS10, Line 332: select id, name, rtrim(name, substr(name, 2)) from utf8_str_tiny Can we add some tests with constant 'chars_to_trim' ? -- To view, visit http://gerrit.cloudera.org:8080/20926 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cfaffd71009f16eae75910af835bd2a34410856 Gerrit-Change-Number: 20926 Gerrit-PatchSet: 10 Gerrit-Owner: Zihao Ye <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Wed, 31 Jan 2024 01:08:40 +0000 Gerrit-HasComments: Yes
