Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20926 )

Change subject: IMPALA-12718: Provides UTF-8 support for the trim functions
......................................................................


Patch Set 11:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20926/11/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

http://gerrit.cloudera.org:8080/#/c/20926/11/be/src/exprs/expr-test.cc@11111
PS11, Line 11111: // Tests *trim() with UTF-8 characters in UTF8_MODE.
Please add trim, ltrim, rtrim, and btrim tests without second argument under 
utf8_mode.



--
To view, visit http://gerrit.cloudera.org:8080/20926
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5cfaffd71009f16eae75910af835bd2a34410856
Gerrit-Change-Number: 20926
Gerrit-PatchSet: 11
Gerrit-Owner: Zihao Ye <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Zihao Ye <[email protected]>
Gerrit-Comment-Date: Thu, 01 Feb 2024 20:27:29 +0000
Gerrit-HasComments: Yes

Reply via email to