Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20986 )
Change subject: IMPALA-12782: Show info of the event processing in /events webUI ...................................................................... Patch Set 1: (31 comments) http://gerrit.cloudera.org:8080/#/c/20986/1/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/20986/1/be/src/catalog/catalog-server.cc@936 PS1, Line 936: const TEventBatchProgressInfo& progress_info = event_processor_summary_response.progress; line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/20986/1/be/src/catalog/catalog-server.cc@943 PS1, Line 943: progress_info_obj.AddMember("last_synced_event_id", last_synced_event_id, document->GetAllocator()); line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/20986/1/be/src/catalog/catalog-server.cc@944 PS1, Line 944: progress_info_obj.AddMember("last_synced_event_time_s", last_synced_event_time_s, document->GetAllocator()); line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/20986/1/be/src/catalog/catalog-server.cc@945 PS1, Line 945: progress_info_obj.AddMember("latest_event_id", latest_event_id, document->GetAllocator()); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/20986/1/be/src/catalog/catalog-server.cc@946 PS1, Line 946: progress_info_obj.AddMember("latest_event_time_s", latest_event_time_s, document->GetAllocator()); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/20986/1/be/src/catalog/catalog-server.cc@947 PS1, Line 947: int64_t lag_time = progress_info.latest_event_time_s - progress_info.last_synced_event_time_s; line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/20986/1/be/src/catalog/catalog-server.cc@948 PS1, Line 948: Value lag_time_str(PrettyPrinter::Print(lag_time, TUnit::TIME_S).c_str(), document->GetAllocator()); line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/20986/1/be/src/catalog/catalog-server.cc@950 PS1, Line 950: Value last_synced_event_time(ToStringFromUnix(progress_info.last_synced_event_time_s).c_str(), document->GetAllocator()); line too long (123 > 90) http://gerrit.cloudera.org:8080/#/c/20986/1/be/src/catalog/catalog-server.cc@951 PS1, Line 951: Value latest_event_time(ToStringFromUnix(progress_info.latest_event_time_s).c_str(), document->GetAllocator()); line too long (113 > 90) http://gerrit.cloudera.org:8080/#/c/20986/1/be/src/catalog/catalog-server.cc@952 PS1, Line 952: progress_info_obj.AddMember("last_synced_event_time", last_synced_event_time, document->GetAllocator()); line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/20986/1/be/src/catalog/catalog-server.cc@953 PS1, Line 953: progress_info_obj.AddMember("latest_event_time", latest_event_time, document->GetAllocator()); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/20986/1/be/src/catalog/catalog-server.cc@959 PS1, Line 959: Value synced_percent(100 * progress_info.current_event_index / progress_info.num_filtered_events); line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/20986/1/be/src/catalog/catalog-server.cc@962 PS1, Line 962: Value min_event_time(ToStringFromUnix(progress_info.min_event_time_s).c_str(), document->GetAllocator()); line too long (109 > 90) http://gerrit.cloudera.org:8080/#/c/20986/1/be/src/catalog/catalog-server.cc@963 PS1, Line 963: Value max_event_time(ToStringFromUnix(progress_info.max_event_time_s).c_str(), document->GetAllocator()); line too long (109 > 90) http://gerrit.cloudera.org:8080/#/c/20986/1/be/src/catalog/catalog-server.cc@964 PS1, Line 964: Value start_time(ToStringFromUnixMillis(progress_info.current_batch_start_time_ms).c_str(), document->GetAllocator()); line too long (122 > 90) http://gerrit.cloudera.org:8080/#/c/20986/1/be/src/catalog/catalog-server.cc@965 PS1, Line 965: Value start_time_of_event(ToStringFromUnixMillis(progress_info.current_event_start_time_ms).c_str(), document->GetAllocator()); line too long (131 > 90) http://gerrit.cloudera.org:8080/#/c/20986/1/be/src/catalog/catalog-server.cc@967 PS1, Line 967: Value elapsed_time(PrettyPrinter::Print(now_ms - progress_info.current_batch_start_time_ms, TUnit::TIME_MS).c_str(), document->GetAllocator()); line too long (147 > 90) http://gerrit.cloudera.org:8080/#/c/20986/1/be/src/catalog/catalog-server.cc@968 PS1, Line 968: Value elapsed_time_current_event(PrettyPrinter::Print(now_ms - progress_info.current_event_start_time_ms, TUnit::TIME_MS).c_str(), document->GetAllocator()); line too long (161 > 90) http://gerrit.cloudera.org:8080/#/c/20986/1/be/src/catalog/catalog-server.cc@969 PS1, Line 969: progress_info_obj.AddMember("num_hms_events", num_hms_events, document->GetAllocator()); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/20986/1/be/src/catalog/catalog-server.cc@970 PS1, Line 970: progress_info_obj.AddMember("num_filtered_events", num_filtered_events, document->GetAllocator()); line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/20986/1/be/src/catalog/catalog-server.cc@971 PS1, Line 971: progress_info_obj.AddMember("num_synced_events", num_synced_events, document->GetAllocator()); line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/20986/1/be/src/catalog/catalog-server.cc@972 PS1, Line 972: progress_info_obj.AddMember("synced_percent", synced_percent, document->GetAllocator()); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/20986/1/be/src/catalog/catalog-server.cc@975 PS1, Line 975: progress_info_obj.AddMember("min_event_time", min_event_time, document->GetAllocator()); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/20986/1/be/src/catalog/catalog-server.cc@976 PS1, Line 976: progress_info_obj.AddMember("max_event_time", max_event_time, document->GetAllocator()); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/20986/1/be/src/catalog/catalog-server.cc@979 PS1, Line 979: progress_info_obj.AddMember("start_time_of_event", start_time_of_event, document->GetAllocator()); line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/20986/1/be/src/catalog/catalog-server.cc@980 PS1, Line 980: progress_info_obj.AddMember("elapsed_time_current_event", elapsed_time_current_event, document->GetAllocator()); line too long (116 > 90) http://gerrit.cloudera.org:8080/#/c/20986/1/be/src/catalog/catalog-server.cc@984 PS1, Line 984: Value event_time(ToStringFromUnix(progress_info.current_event.eventTime).c_str(), document->GetAllocator()); line too long (114 > 90) http://gerrit.cloudera.org:8080/#/c/20986/1/be/src/catalog/catalog-server.cc@985 PS1, Line 985: Value event_type(progress_info.current_event.eventType.c_str(), document->GetAllocator()); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/20986/1/be/src/catalog/catalog-server.cc@986 PS1, Line 986: Value cat_name(progress_info.current_event.catName.c_str(), document->GetAllocator()); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/20986/1/be/src/catalog/catalog-server.cc@988 PS1, Line 988: Value tbl_name(progress_info.current_event.tableName.c_str(), document->GetAllocator()); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/20986/1/be/src/catalog/catalog-server.cc@995 PS1, Line 995: progress_info_obj.AddMember("current_event", current_event, document->GetAllocator()); line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/20986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e7d4952c7fd04ae89b6751204499bf9dd99f57c Gerrit-Change-Number: 20986 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 02 Feb 2024 12:31:14 +0000 Gerrit-HasComments: Yes
