[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/20986 )
Change subject: IMPALA-12782: Show info of the event processing in /events webUI ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/20986/2/common/thrift/JniCatalog.thrift File common/thrift/JniCatalog.thrift: http://gerrit.cloudera.org:8080/#/c/20986/2/common/thrift/JniCatalog.thrift@1066 PS2, Line 1066: 1: required bool is_current_event_batched is_current_event_batched doesn't seem to be used ? http://gerrit.cloudera.org:8080/#/c/20986/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/20986/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@1130 PS2, Line 1130: progressInfo.current_batch_start_time_ms = currentBatchStartTimeMs_; currentEventBatch_, currentFilteredEvents_, currentBatchStartTimeMs_, currentEventStartTimeMs_ and currentEventIndex_ values may not always have the state of current batch. I mean, when some variables of current batch are updated but others are not updated by the time of this execution. Lets say currentEventBatch_ alone is updated or may be currentEventBatch_ and currentBatchStartTimeMs_ are updated or currentEventBatch_, currentBatchStartTimeMs_ and currentFilteredEvents_ are updated and so on. We will have previous batch state for remaining variables. So we may see some inconsistent values. For example, num_synced_events can be seen more than num_hms_events when the previous batch has more events than current batch and currentEventBatch_ variable alone is updated by the time of this execution Similarly other parameters such as synced_percent etc can also be inconsistent. http://gerrit.cloudera.org:8080/#/c/20986/2/www/events.tmpl File www/events.tmpl: http://gerrit.cloudera.org:8080/#/c/20986/2/www/events.tmpl@59 PS2, Line 59: <th>EventId</th> nit: Can we use the same style in both headers ? Event ID or EventId, Event Time or EventTime etc ? -- To view, visit http://gerrit.cloudera.org:8080/20986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e7d4952c7fd04ae89b6751204499bf9dd99f57c Gerrit-Change-Number: 20986 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Wed, 14 Feb 2024 12:17:40 +0000 Gerrit-HasComments: Yes
