Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20915 )
Change subject: IMPALA-12503: Support date data type for predicates for external data source table ...................................................................... Patch Set 16: (2 comments) One more change for FrontendTest.java since we added one more table for unit-test. http://gerrit.cloudera.org:8080/#/c/20915/16/fe/src/test/java/org/apache/impala/service/FrontendTest.java File fe/src/test/java/org/apache/impala/service/FrontendTest.java: http://gerrit.cloudera.org:8080/#/c/20915/16/fe/src/test/java/org/apache/impala/service/FrontendTest.java@146 PS16, Line 146: 5 change 5 to 6 in line 146 since we add one more table 'alltypes_with_date' http://gerrit.cloudera.org:8080/#/c/20915/16/fe/src/test/java/org/apache/impala/service/FrontendTest.java@156 PS16, Line 156: resp.rows.get(4).colVals.get(2).string_val.toLowerCase()); add one assert as: assertEquals("alltypes_with_date", resp.rows.get(5).colVals.get(2).string_val.toLowerCase()); -- To view, visit http://gerrit.cloudera.org:8080/20915 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibf13cbefaad812a0f78755c5791d82b24a3395e4 Gerrit-Change-Number: 20915 Gerrit-PatchSet: 16 Gerrit-Owner: gaurav singh <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Sun, 04 Feb 2024 18:28:14 +0000 Gerrit-HasComments: Yes
