gaurav singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/20915 )
Change subject: IMPALA-12503: Support date data type for predicates for external data source table ...................................................................... Patch Set 17: (3 comments) http://gerrit.cloudera.org:8080/#/c/20915/16/fe/src/test/java/org/apache/impala/service/FrontendTest.java File fe/src/test/java/org/apache/impala/service/FrontendTest.java: http://gerrit.cloudera.org:8080/#/c/20915/16/fe/src/test/java/org/apache/impala/service/FrontendTest.java@146 PS16, Line 146: 6 > change 5 to 6 in line 146 since we add one more table 'alltypes_with_date' Done http://gerrit.cloudera.org:8080/#/c/20915/16/fe/src/test/java/org/apache/impala/service/FrontendTest.java@156 PS16, Line 156: resp.rows.get(4).colVals.get(2).string_val.toLowerCase()); > add one assert as: Done http://gerrit.cloudera.org:8080/#/c/20915/16/testdata/bin/load-ext-data-sources.sh File testdata/bin/load-ext-data-sources.sh: http://gerrit.cloudera.org:8080/#/c/20915/16/testdata/bin/load-ext-data-sources.sh@106 PS16, Line 106: IMPALAD=${IM > change to: Done. Thanks. -- To view, visit http://gerrit.cloudera.org:8080/20915 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibf13cbefaad812a0f78755c5791d82b24a3395e4 Gerrit-Change-Number: 20915 Gerrit-PatchSet: 17 Gerrit-Owner: gaurav singh <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Mon, 05 Feb 2024 16:31:53 +0000 Gerrit-HasComments: Yes
