Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21003 )
Change subject: IMPALA-12788: Fix HBaseTable still get loaded even if HBase is down ...................................................................... Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/21003/1/fe/src/main/java/org/apache/impala/catalog/HBaseTable.java File fe/src/main/java/org/apache/impala/catalog/HBaseTable.java: http://gerrit.cloudera.org:8080/#/c/21003/1/fe/src/main/java/org/apache/impala/catalog/HBaseTable.java@142 PS1, Line 142: // Warm up the connection and verify the table exists. : getColumnFamilies(); Before the change columnFamilies_ was set to null at the end of the try block - was it intenional to leave it as null? http://gerrit.cloudera.org:8080/#/c/21003/1/testdata/workloads/functional-query/queries/QueryTest/struct-in-select-list-error.test File testdata/workloads/functional-query/queries/QueryTest/struct-in-select-list-error.test: http://gerrit.cloudera.org:8080/#/c/21003/1/testdata/workloads/functional-query/queries/QueryTest/struct-in-select-list-error.test@10 PS1, Line 10: # It's not supported to create a view with structs from a file format that doesn't Not sure here, but it seems a bit better to me to keep the non hbase errors in the original file. Running these only in environments with hbase wouldn't cause problems, but it is not intuitive. -- To view, visit http://gerrit.cloudera.org:8080/21003 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib497f11ecc338d0f84d3d7bd8ccfcf8da4def0cb Gerrit-Change-Number: 21003 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 07 Feb 2024 14:15:27 +0000 Gerrit-HasComments: Yes
