Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21003 )
Change subject: IMPALA-12788: Fix HBaseTable still get loaded even if HBase is down ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/21003/1/fe/src/main/java/org/apache/impala/catalog/HBaseTable.java File fe/src/main/java/org/apache/impala/catalog/HBaseTable.java: http://gerrit.cloudera.org:8080/#/c/21003/1/fe/src/main/java/org/apache/impala/catalog/HBaseTable.java@142 PS1, Line 142: // Warm up the connection and verify the table exists. : getColumnFamilies(); > Before the change columnFamilies_ was set to null at the end of the try blo That line was added ~10 years ago: https://github.com/apache/impala/commit/2dea6708b240c3f51c4b815d739fc9746d37f4e2 I think it's redundant since if we leave columnFamilies_ as null, it needs to be fetched again in getEstimatedRowStats(). That could block queries when the table is first used. http://gerrit.cloudera.org:8080/#/c/21003/1/testdata/workloads/functional-query/queries/QueryTest/struct-in-select-list-error.test File testdata/workloads/functional-query/queries/QueryTest/struct-in-select-list-error.test: http://gerrit.cloudera.org:8080/#/c/21003/1/testdata/workloads/functional-query/queries/QueryTest/struct-in-select-list-error.test@10 PS1, Line 10: > Not sure here, but it seems a bit better to me to keep the non hbase errors Done -- To view, visit http://gerrit.cloudera.org:8080/21003 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib497f11ecc338d0f84d3d7bd8ccfcf8da4def0cb Gerrit-Change-Number: 21003 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 09 Feb 2024 02:32:21 +0000 Gerrit-HasComments: Yes
