Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 )
Change subject: IMPALA-12503 PART-2: Support timestamp for predicates for external data source table ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/21015/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21015/2//COMMIT_MSG@7 PS2, Line 7: IMPALA-12503 PART-2: Support timestamp for Much cleaner to create a separate JIRA for timestamp support http://gerrit.cloudera.org:8080/#/c/21015/2//COMMIT_MSG@10 PS2, Line 10: This patch adds support for timestamp as predicates We should be more specific here, we're only talking about SCAN predicates here. Also, would be good to add some high level details summarizing the patch here. Right now the commit message is same as the title. http://gerrit.cloudera.org:8080/#/c/21015/2//COMMIT_MSG@14 PS2, Line 14: - Added tests for date predicates with operators: Would be good to be more specific about what kind of tests: e2e, unit, custom cluster? http://gerrit.cloudera.org:8080/#/c/21015/2/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java File fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java: http://gerrit.cloudera.org:8080/#/c/21015/2/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java@150 PS2, Line 150: String[] parts = timestamp_col.split("'"); No need to call toSql() and extract the string value by parsing it. You could simply call getStringValue() on the TimestampLiteral object. -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 2 Gerrit-Owner: gaurav singh <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 14 Feb 2024 19:16:35 +0000 Gerrit-HasComments: Yes
