gaurav singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 )
Change subject: IMPALA-12503 PART-2: Support timestamp for predicates for external data source table ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/21015/2/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java File fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java: http://gerrit.cloudera.org:8080/#/c/21015/2/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java@145 PS2, Line 145: > rename timestamp_col to timestampVal Thanks. Changed to getStringValue() The timestamp is of the ISO 8601 format(SQL standard): 'yyyy-mm-dd hh:mm:ss.ms'. So far, I checked its followed by most major databases. http://gerrit.cloudera.org:8080/#/c/21015/2/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java@150 PS2, Line 150: ((TimestampLiteral) expr).getStringValue()); > No need to call toSql() and extract the string value by parsing it. You cou Done http://gerrit.cloudera.org:8080/#/c/21015/2/testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables-predicates.test File testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables-predicates.test: http://gerrit.cloudera.org:8080/#/c/21015/2/testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables-predicates.test@278 PS2, Line 278: > remove extra space Done http://gerrit.cloudera.org:8080/#/c/21015/2/testdata/workloads/functional-query/queries/QueryTest/jdbc-data-source.test File testdata/workloads/functional-query/queries/QueryTest/jdbc-data-source.test: http://gerrit.cloudera.org:8080/#/c/21015/2/testdata/workloads/functional-query/queries/QueryTest/jdbc-data-source.test@408 PS2, Line 408: > remove extra space Done http://gerrit.cloudera.org:8080/#/c/21015/2/testdata/workloads/functional-query/queries/QueryTest/mysql-ext-jdbc-tables.test File testdata/workloads/functional-query/queries/QueryTest/mysql-ext-jdbc-tables.test: http://gerrit.cloudera.org:8080/#/c/21015/2/testdata/workloads/functional-query/queries/QueryTest/mysql-ext-jdbc-tables.test@408 PS2, Line 408: > remove extra space Done -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 3 Gerrit-Owner: gaurav singh <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Wed, 14 Feb 2024 19:20:42 +0000 Gerrit-HasComments: Yes
