Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21029 )
Change subject: IMPALA-12543: Deflake test_iceberg_self_events ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/21029/2/fe/src/main/java/org/apache/impala/catalog/InflightEventParam.java File fe/src/main/java/org/apache/impala/catalog/InflightEventParam.java: http://gerrit.cloudera.org:8080/#/c/21029/2/fe/src/main/java/org/apache/impala/catalog/InflightEventParam.java@40 PS2, Line 40: addVersionsForInflightEvent > addVersionsForInflightEvents should return True/False on whether it success Done http://gerrit.cloudera.org:8080/#/c/21029/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/21029/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1089 PS2, Line 1089: return; > reloadMetadata should set to false if return early like here, line 1102, an Done -- To view, visit http://gerrit.cloudera.org:8080/21029 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8365c934349ad21a4d9327fc11594d2fc3445f79 Gerrit-Change-Number: 21029 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Mon, 19 Feb 2024 05:09:01 +0000 Gerrit-HasComments: Yes
