Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21029 )
Change subject: IMPALA-12543: Detect self-events before finishing DDL ...................................................................... Patch Set 5: (7 comments) http://gerrit.cloudera.org:8080/#/c/21029/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21029/3//COMMIT_MSG@7 PS3, Line 7: Detect self-events before finish > I think that the title is a bit misleading, as this is an actual bug (thoug Done http://gerrit.cloudera.org:8080/#/c/21029/3//COMMIT_MSG@15 PS3, Line 15: g db/table self-ev > Can you mention that currently this is only relevant for table level events Done http://gerrit.cloudera.org:8080/#/c/21029/3/fe/src/main/java/org/apache/impala/catalog/InflightEventParam.java File fe/src/main/java/org/apache/impala/catalog/InflightEventParam.java: http://gerrit.cloudera.org:8080/#/c/21029/3/fe/src/main/java/org/apache/impala/catalog/InflightEventParam.java@23 PS3, Line 23: InflightEventParam > Just an idea: Done. Added methods about InProgressTableModification in Table class. http://gerrit.cloudera.org:8080/#/c/21029/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/21029/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1120 PS3, Line 1120: TAlterTableAddColsParams addColParams = params.get > Would it be possible to move this inside applyAlterTable()? My assumption i Done http://gerrit.cloudera.org:8080/#/c/21029/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1325 PS3, Line 1325: || type == TAlterTableType.DROP_COLUMN > Can you add some logging? This should be an unusual case, so it could be a Done. http://gerrit.cloudera.org:8080/#/c/21029/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/21029/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1683 PS5, Line 1683: applyAlterTable(msTbl, true, null); Original code never put in-flight event for ALTER VIEW. Please advise. http://gerrit.cloudera.org:8080/#/c/21029/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3807 PS5, Line 3807: applyAlterTable(msTable, true, null); Original code never put in-flight event for createTable. Probably because acquireMetastoreDdlLock() is called prior to this. Please advise. -- To view, visit http://gerrit.cloudera.org:8080/21029 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8365c934349ad21a4d9327fc11594d2fc3445f79 Gerrit-Change-Number: 21029 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Wed, 21 Feb 2024 03:08:09 +0000 Gerrit-HasComments: Yes
