Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21045 )
Change subject: IMPALA-12771: Impala catalogd events-skipped may mark the wrong number ...................................................................... Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/21045/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/21045/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1056 PS1, Line 1056: metrics_.getCounter(MetastoreEventsProcessor.EVENTS_SKIPPED_METRIC).inc(partitions.size()); line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/21045/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1662 PS1, Line 1662: // both old table not removed and new table not add, that means we skip the rename event process line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/21045/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1663 PS1, Line 1663: // if one is true and the other is false, that means we need to use the function(removeTableIfNotAddedLater/addTableIfNotRemovedLater) line too long (140 > 90) http://gerrit.cloudera.org:8080/#/c/21045/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2633 PS1, Line 2633: int skippedNum = batchedEvents_.size() - eventsToProcess.size() - partitionEventsToForceReload.size(); line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/21045/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2635 PS1, Line 2635: metrics_.getCounter(MetastoreEventsProcessor.EVENTS_SKIPPED_METRIC).inc(skippedNum); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21045/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/21045/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@235 PS1, Line 235: // in case of [CREATE|DROP|ALTER] events on [DATABASE|TABLE|PARTITION] which were ignored line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/21045/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/21045/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@1986 PS1, Line 1986: // I think the reason why using >= is that when process create table event the table is IncompleteTable line too long (107 > 90) http://gerrit.cloudera.org:8080/#/c/21045/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@2034 PS1, Line 2034: // invalidate the table and the table will be IncompleteTable, then alter event process will skip; line too long (102 > 90) -- To view, visit http://gerrit.cloudera.org:8080/21045 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7aeb04e999b82187eb138c0b643ead259da22f1a Gerrit-Change-Number: 21045 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 21 Feb 2024 12:10:29 +0000 Gerrit-HasComments: Yes
