[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/21045 )
Change subject: IMPALA-12771: Impala catalogd events-skipped may mark the wrong number ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/21045/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/21045/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1055 PS1, Line 1055: } else if (numPartsRefreshed == -1) { > I think using "else" without the condition is more robust in case the retur Hi, the reason that I change the catalogOpExecutor_.reloadPartitionsIfExist result from 0 to -1 for cases like : table does not exist or table is IncompleteTable. This means the table has no need to reload the partition, -1 is just a marker for me , But if the result is 0, that may means the function(hdfsTable.reloadPartitionsFromNames() to do real partition may has been executed but the result is 0 which means the event is not skipped but been executed. http://gerrit.cloudera.org:8080/#/c/21045/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1056 PS1, Line 1056: inc > Please add a debug log when increasing this counter. ok http://gerrit.cloudera.org:8080/#/c/21045/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2341 PS1, Line 2341: debugLog("Incremented skipped metric to " + metrics_ > We can improve this to add the reason - "since no partitions were added" ok -- To view, visit http://gerrit.cloudera.org:8080/21045 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7aeb04e999b82187eb138c0b643ead259da22f1a Gerrit-Change-Number: 21045 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 05 Mar 2024 03:07:43 +0000 Gerrit-HasComments: Yes
