gaurav singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 )
Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. ...................................................................... Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/21015/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21015/5//COMMIT_MSG@16 PS5, Line 16: postgre > nit: Postgres Done http://gerrit.cloudera.org:8080/#/c/21015/5//COMMIT_MSG@17 PS5, Line 17: remote > nit: remote impala Done http://gerrit.cloudera.org:8080/#/c/21015/5//COMMIT_MSG@19 PS5, Line 19: timestam > nit: timestamp Done http://gerrit.cloudera.org:8080/#/c/21015/5/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java File fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java: http://gerrit.cloudera.org:8080/#/c/21015/5/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java@33 PS5, Line 33: import org.apache.impala.analysis.Expr; > nit: keep alphabet order Thanks. Moved it to above the TupleDescriptor. http://gerrit.cloudera.org:8080/#/c/21015/5/testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables-predicates.test File testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables-predicates.test: http://gerrit.cloudera.org:8080/#/c/21015/5/testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables-predicates.test@275 PS5, Line 275: between > it's better to use count(*) for 'between', like select count(*) from alltyp Done. Thanks. Changed it for mysql and postgres as well. -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 6 Gerrit-Owner: gaurav singh <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Thu, 22 Feb 2024 17:25:18 +0000 Gerrit-HasComments: Yes
