Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21048 )
Change subject: IMPALA-12426: Workload Management Supporting Changes ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/21048/8/be/src/util/string-util-test.cc File be/src/util/string-util-test.cc: http://gerrit.cloudera.org:8080/#/c/21048/8/be/src/util/string-util-test.cc@326 PS8, Line 326: expected << "C++ is" << " an " << "invisible found" << "ation of " << "everything!"; : fixture << "C++ is" << " an " << "invisible found" << "ation of " << "everything?" > nit: What if we do this for little bit complexity? I agree, why not? Done. -- To view, visit http://gerrit.cloudera.org:8080/21048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee23334ec56a18b192a75d052468bf59159b6424 Gerrit-Change-Number: 21048 Gerrit-PatchSet: 10 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 23 Feb 2024 23:11:11 +0000 Gerrit-HasComments: Yes
