Hello Riza Suminto, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21048
to look at the new patch set (#13).
Change subject: IMPALA-12426: Workload Management Supporting Changes
......................................................................
IMPALA-12426: Workload Management Supporting Changes
Contains several disparate pieces of functionality that support the
overall workload management work.
1. TNetworkAddressComparator
An unused existing comparator for the Thrift class TNetworkAddress
already existed in the thrift-util.h file. This comparator has been
moved to the network-util.h file where it now resides in the same
place as other utility functions that operator on TNetworkAddress
instances.
The existing comparator did not consider the uds address. It only
considered hostname and port. The new comparator considers all three.
Testing is accomplished by porting the existing ctests and adding
additional ctests.
2. StringStreamPop
This new class extends a std::basic_stringstream<char> to add a
function that enables removing a character from the end.
Testing is accomplished using new ctests.
3. Ticker
This new header-only class notifies a condition variable at periodic
intervals. It is a lightweight that sleeps until the configured
duration has passed at which point it wakes up and notifies the
condition variable. It also enables consumers to offload spurious
wakeup guards to this class.
Ctests have been added to test the functionality of this new class.
4. TUniqueId Empty Utility Function
A new function UUIDEmpty returns true if a provided TUniqueID does
not contain a UUID or false otherwise.
Ctests have been added to test this new function.
5. run_clang_tidy.sh
Additional informational outputs have been added to this script to
enable tracking the status of the script and to easily identify
errors found by clang tidy.
6. Summary Util Test
A ctest was developed for testing the text table generation code that
generates the exec summary portion of the query profile. This ctest
was developed as part of an idea that did not ultimately pan out.
Rather than throwing away that test code, it has been added as a new
ctest.
Change-Id: Iee23334ec56a18b192a75d052468bf59159b6424
---
M be/src/rpc/thrift-util-test.cc
M be/src/rpc/thrift-util.cc
M be/src/rpc/thrift-util.h
M be/src/util/CMakeLists.txt
A be/src/util/network-util-test.cc
M be/src/util/network-util.cc
M be/src/util/network-util.h
M be/src/util/string-util-test.cc
M be/src/util/string-util.cc
M be/src/util/string-util.h
A be/src/util/summary-util-test.cc
A be/src/util/ticker-test.cc
A be/src/util/ticker.h
M be/src/util/uid-util-test.cc
M be/src/util/uid-util.h
M bin/run_clang_tidy.sh
16 files changed, 647 insertions(+), 28 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/48/21048/13
--
To view, visit http://gerrit.cloudera.org:8080/21048
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iee23334ec56a18b192a75d052468bf59159b6424
Gerrit-Change-Number: 21048
Gerrit-PatchSet: 13
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
