Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10251 )
Change subject: IMPALA-6954: Fix problems with CTAS into Kudu with an expr rewrite ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/10251/1/fe/src/main/java/org/apache/impala/analysis/TableDataLayout.java File fe/src/main/java/org/apache/impala/analysis/TableDataLayout.java: http://gerrit.cloudera.org:8080/#/c/10251/1/fe/src/main/java/org/apache/impala/analysis/TableDataLayout.java@57 PS1, Line 57: partitionColDefs_.clear(); Why would this class even have a reset()? That function is used to wipe analysis state, but this class has no analyze(). Can we remove reset() entirely? http://gerrit.cloudera.org:8080/#/c/10251/1/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test File testdata/workloads/functional-query/queries/QueryTest/kudu_create.test: http://gerrit.cloudera.org:8080/#/c/10251/1/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test@340 PS1, Line 340: # CTAS with an expr rewrite. IMPALA-6954: CTAS ... -- To view, visit http://gerrit.cloudera.org:8080/10251 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I731743bd84cc695119e99342e1b155096147f0ed Gerrit-Change-Number: 10251 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Zoram Thanga <[email protected]> Gerrit-Comment-Date: Tue, 01 May 2018 16:05:31 +0000 Gerrit-HasComments: Yes
