Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10251 )
Change subject: IMPALA-6954: Fix problems with CTAS into Kudu with an expr rewrite ...................................................................... Patch Set 2: (2 comments) Alex - can you think of any situations where an expr rewrite would happen for a CREATE TABLE that's not a CTAS (if so, then this patch doesn't solve all the problems, but I don't think its possible)? http://gerrit.cloudera.org:8080/#/c/10251/1/fe/src/main/java/org/apache/impala/analysis/TableDataLayout.java File fe/src/main/java/org/apache/impala/analysis/TableDataLayout.java: http://gerrit.cloudera.org:8080/#/c/10251/1/fe/src/main/java/org/apache/impala/analysis/TableDataLayout.java@57 PS1, Line 57: partitionColDefs_.clear(); > Why would this class even have a reset()? That function is used to wipe ana This was introduced in: https://gerrit.cloudera.org/#/c/8930/ It's needed for partitionColDefs_ because that list is constructed during CreateTableAsSelectStmt::analyze(). Maybe it would be cleaner to just call clear() in CreateTableAsSelectStmt::reset()? http://gerrit.cloudera.org:8080/#/c/10251/1/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test File testdata/workloads/functional-query/queries/QueryTest/kudu_create.test: http://gerrit.cloudera.org:8080/#/c/10251/1/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test@340 PS1, Line 340: # IMPALA-6954: CTAS with an expr rewrite. > IMPALA-6954: CTAS ... Done -- To view, visit http://gerrit.cloudera.org:8080/10251 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I731743bd84cc695119e99342e1b155096147f0ed Gerrit-Change-Number: 10251 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Zoram Thanga <[email protected]> Gerrit-Comment-Date: Tue, 01 May 2018 18:22:02 +0000 Gerrit-HasComments: Yes
