Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21064 )
Change subject: IMPALA-12840: Exclude THdfsFileDesc in getJsonCatalogObject ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/21064/2/fe/src/main/java/org/apache/impala/catalog/Table.java File fe/src/main/java/org/apache/impala/catalog/Table.java: http://gerrit.cloudera.org:8080/#/c/21064/2/fe/src/main/java/org/apache/impala/catalog/Table.java@709 PS2, Line 709: * Variant of toThrift() with lower detail. Intended for test/debugging purpose. nit: This is also returned in a user-facing API. Debugging to me implies developer audience, so maybe broaden this a little to human-readable? http://gerrit.cloudera.org:8080/#/c/21064/2/fe/src/main/java/org/apache/impala/service/JniCatalog.java File fe/src/main/java/org/apache/impala/service/JniCatalog.java: http://gerrit.cloudera.org:8080/#/c/21064/2/fe/src/main/java/org/apache/impala/service/JniCatalog.java@404 PS2, Line 404: * slimer than the one obtained from getCatalogObject() because binary data fields typo: slimmer -- To view, visit http://gerrit.cloudera.org:8080/21064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5f6840bf1267d1d99d321c0a6b4a0cab49543182 Gerrit-Change-Number: 21064 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 26 Feb 2024 17:07:56 +0000 Gerrit-HasComments: Yes
