Hello Quanlong Huang, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21064
to look at the new patch set (#4).
Change subject: IMPALA-12840: Exclude THdfsFileDesc in getJsonCatalogObject
......................................................................
IMPALA-12840: Exclude THdfsFileDesc in getJsonCatalogObject
TestReusePartitions::test_reuse_partitions_transactional calls
/catalog_object path of CatalogD's WebUI and decodes the JSON response.
The "json_string" field from the response text often contains Unicode
control characters that come from serialized binary data from
THdfsFileDesc objects. That causes JSON decoding to fail with an error
like this:
ValueError: Invalid control character at: line 1 column 1850 (char 1849)
This patch attempts to deflake the test by tuning the return value of
getJsonCatalogObject() that excludes THdfsFileDesc, by lowering the
detail level from ThriftObjectType.FULL to
ThriftObjectType.DESCRIPTOR_ONLY.
test_reuse_partitions_transactional is tweaked a bit to print the
response / JSON object if an assertion fails.
Testing:
- Loop and pass the test for hundred times.
Change-Id: I5f6840bf1267d1d99d321c0a6b4a0cab49543182
---
M fe/src/main/java/org/apache/impala/catalog/Catalog.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/service/JniCatalog.java
M tests/metadata/test_reuse_partitions.py
6 files changed, 54 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/21064/4
--
To view, visit http://gerrit.cloudera.org:8080/21064
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5f6840bf1267d1d99d321c0a6b4a0cab49543182
Gerrit-Change-Number: 21064
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
