Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21016 )
Change subject: IMPALA-12793: Create JDBC table without data source ...................................................................... Patch Set 6: (1 comment) One small thing, but otherwise this looks good to me http://gerrit.cloudera.org:8080/#/c/21016/6/tests/custom_cluster/test_ext_data_sources.py File tests/custom_cluster/test_ext_data_sources.py: http://gerrit.cloudera.org:8080/#/c/21016/6/tests/custom_cluster/test_ext_data_sources.py@a102 PS6, Line 102: : : : : : : Nit: Is this test now obsolete? If we think we want to remove the persisted data source, we can do that in a separate change (though I don't think we need to remove it). -- To view, visit http://gerrit.cloudera.org:8080/21016 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I765aa86b430246786ad85ab6857cefaf4332c920 Gerrit-Change-Number: 21016 Gerrit-PatchSet: 6 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Mon, 26 Feb 2024 18:30:43 +0000 Gerrit-HasComments: Yes
