Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21016 )
Change subject: IMPALA-12793: Create JDBC table without data source ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/21016/6/tests/custom_cluster/test_ext_data_sources.py File tests/custom_cluster/test_ext_data_sources.py: http://gerrit.cloudera.org:8080/#/c/21016/6/tests/custom_cluster/test_ext_data_sources.py@a102 PS6, Line 102: : : : : : : > In IMPALA-12833, we will set default value of flag variable 'catalogd_ha_r I am fine with removing the test, but I don't see a direct connection between this test and the rest of this code change. Why are we removing it in this particular code change? If IMPALA-12833 is making it obsolete, then maybe IMPALA-12833 can remove it. -- To view, visit http://gerrit.cloudera.org:8080/21016 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I765aa86b430246786ad85ab6857cefaf4332c920 Gerrit-Change-Number: 21016 Gerrit-PatchSet: 6 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: gaurav singh <gsi...@cloudera.com> Gerrit-Comment-Date: Mon, 26 Feb 2024 19:51:07 +0000 Gerrit-HasComments: Yes
