Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9799 )
Change subject: IMPALA-4123 (prep): Parquet column reader cleanup ...................................................................... Patch Set 5: (5 comments) Had only minor comments. http://gerrit.cloudera.org:8080/#/c/9799/5/be/src/exec/parquet-column-readers.cc File be/src/exec/parquet-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/9799/5/be/src/exec/parquet-column-readers.cc@270 PS5, Line 270: Can you add a comment to describe the difference between the two? http://gerrit.cloudera.org:8080/#/c/9799/5/be/src/exec/parquet-column-readers.cc@413 PS5, Line 413: , dict_decoder_ is uninitialized I think this comment could be more clear, e.g. ", we don't need to decode any values and dict_decoder_ does not need to be uninitialized." http://gerrit.cloudera.org:8080/#/c/9799/5/be/src/exec/parquet-column-readers.cc@456 PS5, Line 456: template<typename InternalType, parquet::Type::type PARQUET_TYPE, bool MATERIALIZED> nit: space? http://gerrit.cloudera.org:8080/#/c/9799/5/be/src/exec/parquet-column-readers.cc@463 PS5, Line 463: if (IN_COLLECTION) nit: else? http://gerrit.cloudera.org:8080/#/c/9799/5/be/src/exec/parquet-column-readers.cc@517 PS5, Line 517: template<typename InternalType, parquet::Type::type PARQUET_TYPE, bool MATERIALIZED> nit: space missing? -- To view, visit http://gerrit.cloudera.org:8080/9799 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc00352df3a0b2d605f872ae7e43db2dc90faab1 Gerrit-Change-Number: 9799 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 01 May 2018 18:12:24 +0000 Gerrit-HasComments: Yes
