Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9799 )
Change subject: IMPALA-4123 (prep): Parquet column reader cleanup ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9799/1/be/src/exec/parquet-column-readers.cc File be/src/exec/parquet-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/9799/1/be/src/exec/parquet-column-readers.cc@597 PS1, Line 597: template <Encoding::type ENCODING> > Ahh, I missed this. Unfortunately it looks like there's some reason that is Sorry, I was wrong here, and I don't know of any good alternative. If ENCODING was used as an argument's type, then using overloading instead of function template would do the job. http://gerrit.cloudera.org:8080/#/c/9799/2/be/src/exec/parquet-column-readers.cc File be/src/exec/parquet-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/9799/2/be/src/exec/parquet-column-readers.cc@299 PS2, Line 299: bool ReadValueBatch(MemPool* RESTRICT pool, int max_values, int tuple_size, > I realised I should probably move some of these large functions out-of-line I also found it quite hard to navigate in this file. I think that the real solution would be to split it into more files, mainly by moving scalar column stuff to its own h/cc, and possible do the same with CollectionColumnReader. This would make cherry picking harder, but moving function bodies within the file can lead to similar issues. -- To view, visit http://gerrit.cloudera.org:8080/9799 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc00352df3a0b2d605f872ae7e43db2dc90faab1 Gerrit-Change-Number: 9799 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 28 Mar 2018 14:30:40 +0000 Gerrit-HasComments: Yes