Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20770 )
Change subject: IMPALA-12426: Query History Table ...................................................................... Patch Set 29: (6 comments) http://gerrit.cloudera.org:8080/#/c/20770/29/tests/common/impala_connection.py File tests/common/impala_connection.py: http://gerrit.cloudera.org:8080/#/c/20770/29/tests/common/impala_connection.py@31 PS29, Line 31: from ImpalaService import ImpalaHiveServer2Service flake8: F401 'ImpalaService.ImpalaHiveServer2Service' imported but unused http://gerrit.cloudera.org:8080/#/c/20770/29/tests/custom_cluster/test_query_log.py File tests/custom_cluster/test_query_log.py: http://gerrit.cloudera.org:8080/#/c/20770/29/tests/custom_cluster/test_query_log.py@490 PS29, Line 490: \ flake8: E502 the backslash is redundant between brackets http://gerrit.cloudera.org:8080/#/c/20770/29/tests/custom_cluster/test_query_log.py@491 PS29, Line 491: \ flake8: W605 invalid escape sequence '\)' http://gerrit.cloudera.org:8080/#/c/20770/29/tests/custom_cluster/test_query_log.py@491 PS29, Line 491: \ flake8: W605 invalid escape sequence '\s' http://gerrit.cloudera.org:8080/#/c/20770/29/tests/custom_cluster/test_query_log.py@491 PS29, Line 491: \ flake8: W605 invalid escape sequence '\S' http://gerrit.cloudera.org:8080/#/c/20770/29/tests/util/memory.py File tests/util/memory.py: http://gerrit.cloudera.org:8080/#/c/20770/29/tests/util/memory.py@30 PS29, Line 30: def convert_to_bytes(mem_str, unit_combined=False, factor=1024): flake8: E302 expected 2 blank lines, found 1 -- To view, visit http://gerrit.cloudera.org:8080/20770 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d2da9d450fba4e789400cfa62927fc25d34f844 Gerrit-Change-Number: 20770 Gerrit-PatchSet: 29 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 04 Mar 2024 20:25:30 +0000 Gerrit-HasComments: Yes
