Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20770 )
Change subject: IMPALA-12426: Query History Table ...................................................................... Patch Set 31: (8 comments) http://gerrit.cloudera.org:8080/#/c/20770/22/be/src/service/impala-http-handler.h File be/src/service/impala-http-handler.h: http://gerrit.cloudera.org:8080/#/c/20770/22/be/src/service/impala-http-handler.h@210 PS22, Line 210: void QueryStateToJson(const QueryStateRecord& record, Shouldn't this be updated in the parent patch? Same with impala-http-handler.cc changes. Please do a test build with each patch to make sure it still compiles on its own, rather than requiring the full change stack. http://gerrit.cloudera.org:8080/#/c/20770/31/be/src/service/workload-management.cc File be/src/service/workload-management.cc: http://gerrit.cloudera.org:8080/#/c/20770/31/be/src/service/workload-management.cc@218 PS31, Line 218: for (auto iter = sql.cbegin(); iter != sql.cend(); iter++) { Could be a range-based for loop taking 'const auto&' (always a good default). http://gerrit.cloudera.org:8080/#/c/20770/31/be/src/service/workload-management.cc@393 PS31, Line 393: for (auto iter = ctx.record->per_host_state.cbegin(); Could be a range-based for loop taking 'const auto&'. http://gerrit.cloudera.org:8080/#/c/20770/31/be/src/service/workload-management.cc@659 PS31, Line 659: fields_.push_back(MakeTuple( Lines 659-677 should be indented. http://gerrit.cloudera.org:8080/#/c/20770/31/be/src/service/workload-management.cc@687 PS31, Line 687: for (auto iter = fields_.cbegin(); iter != fields_.cend(); iter++) { Could be a range-based for loop (const auto&). http://gerrit.cloudera.org:8080/#/c/20770/31/be/src/service/workload-management.cc@726 PS31, Line 726: for (auto iter = fields_.cbegin(); iter != fields_.cend(); iter++) { Range-based for loop. http://gerrit.cloudera.org:8080/#/c/20770/31/be/src/service/workload-management.cc@895 PS31, Line 895: for (auto iter = queries_to_insert.begin(); iter != queries_to_insert.end(); Could be a range-based for loop taking a ref (to update the count). http://gerrit.cloudera.org:8080/#/c/20770/31/be/src/service/workload-management.cc@953 PS31, Line 953: for (auto iter = fields_.cbegin(); iter != fields_.cend(); iter++) { Range-based for loop. -- To view, visit http://gerrit.cloudera.org:8080/20770 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d2da9d450fba4e789400cfa62927fc25d34f844 Gerrit-Change-Number: 20770 Gerrit-PatchSet: 31 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 04 Mar 2024 22:41:56 +0000 Gerrit-HasComments: Yes
