Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21100 )
Change subject: IMPALA-12864: Deflake test_query_log_size_in_bytes. ...................................................................... Patch Set 9: (1 comment) Thanks all for the review! http://gerrit.cloudera.org:8080/#/c/21100/9/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/21100/9/be/src/service/impala-server.cc@1167 PS9, Line 1167: ImpaladMetrics::QUERY_LOG_EST_TOTAL_BYTES->Increment(record_size); > It would make sense to me for this to be tied to the server rather than a g Right, it looks weird to maintain a state in ImpaladMetrics, but I rather have single place to track this. -- To view, visit http://gerrit.cloudera.org:8080/21100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9b543ffa931a01c11d58e45774ea46af78b3a25 Gerrit-Change-Number: 21100 Gerrit-PatchSet: 9 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 04 Mar 2024 22:15:00 +0000 Gerrit-HasComments: Yes
