Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21100 )
Change subject: IMPALA-12864: Deflake test_query_log_size_in_bytes. ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/21100/7/be/src/util/impalad-metrics.h File be/src/util/impalad-metrics.h: http://gerrit.cloudera.org:8080/#/c/21100/7/be/src/util/impalad-metrics.h@267 PS7, Line 267: static const char* QUERY_LOG_EST_TOTAL_BYTES; > Nit: rename to match new metric name QUERY_LOG_EST_TOTAL_BYTES Done http://gerrit.cloudera.org:8080/#/c/21100/7/be/src/util/impalad-metrics.h@351 PS7, Line 351: static IntGauge* QUERY_LOG_EST_TOTAL_BYTES; > Nit: rename to match new metric name QUERY_LOG_EST_TOTAL_BYTES Done -- To view, visit http://gerrit.cloudera.org:8080/21100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9b543ffa931a01c11d58e45774ea46af78b3a25 Gerrit-Change-Number: 21100 Gerrit-PatchSet: 9 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 04 Mar 2024 21:17:26 +0000 Gerrit-HasComments: Yes
