Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/21105 )
Change subject: IMPALA-12845: Crash with DESCRIBE on a complex type from an Iceberg table ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/21105/1/fe/src/main/java/org/apache/impala/analysis/DescribeTableStmt.java File fe/src/main/java/org/apache/impala/analysis/DescribeTableStmt.java: http://gerrit.cloudera.org:8080/#/c/21105/1/fe/src/main/java/org/apache/impala/analysis/DescribeTableStmt.java@105 PS1, Line 105: You could call super.analyze(analyzer) here: it sets the analyzer_, and with that it implicitly sets isAnalyzed() to true. There will be no need to set the analyzer_ in line 144 and 170. This is also the general logic in other Stmt classes that inherit from StatementBase. -- To view, visit http://gerrit.cloudera.org:8080/21105 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5eda21a41167cc1fda183aa16fd6276a6a16f5d3 Gerrit-Change-Number: 21105 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 05 Mar 2024 10:52:15 +0000 Gerrit-HasComments: Yes
